14 // Adds metadata option to add chunks to metadata #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartjohnpage
requested review from
estreeper,
grossvogel,
quinnmccourt and
gk-per
|
I'm closing this for now, pending discussion in #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #14
Overview
The thing I don't like about this is the empty
metadataproperty that we now get on chunks. I was toying with either a) doing some fancy macro that can switch up the struct definition, or defaulting it to nil. Or this might actually be a good thing/necessary evil to get the struct definition nice and stableEither way, please let me know what you think. Is this what you had in mind @gordoneliel?